Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up streaming callbacks #209

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Tidy up streaming callbacks #209

merged 1 commit into from
Sep 17, 2024

Conversation

svilupp
Copy link
Owner

@svilupp svilupp commented Sep 17, 2024

  • Relaxed the type-assertions in StreamCallback to allow for more flexibility.

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (17cea6b) to head (524bf28).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          46       46           
  Lines        4406     4406           
=======================================
  Hits         4047     4047           
  Misses        359      359

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svilupp svilupp merged commit f20f3b9 into main Sep 17, 2024
6 checks passed
@svilupp svilupp deleted the extend-streaming branch September 17, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@svilupp